Fixes Uncaught TypeError on getDevice due to default being empty#66
Merged
AltamashShaikh merged 3 commits into5.x-devfrom Nov 21, 2023
Merged
Fixes Uncaught TypeError on getDevice due to default being empty#66AltamashShaikh merged 3 commits into5.x-devfrom
AltamashShaikh merged 3 commits into5.x-devfrom
Conversation
Contributor
|
@AltamashShaikh It looks like the test case that I added needs to be updated corresponding to your change. |
Contributor
Author
@snake14 Yes, updated and added 1 more new case |
snake14
approved these changes
Nov 20, 2023
Contributor
snake14
left a comment
snake14
left a comment
There was a problem hiding this comment.
Looks alright to me. I don't see any errors when I view Device Detection in my local instance.
sgiehl
reviewed
Nov 20, 2023
tsteur
approved these changes
Nov 20, 2023
Member
tsteur
left a comment
tsteur
left a comment
There was a problem hiding this comment.
Nice, and thanks for adding the test 👍 💯
sgiehl
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes Uncaught TypeError on getDevice due to default being empty
Fixes: matomo-org/matomo#21572
Review