useful tag name for MRs, added imageTagPrefix and imageTagSuffix#11
useful tag name for MRs, added imageTagPrefix and imageTagSuffix#11matootie merged 3 commits intomatootie:masterfrom
Conversation
|
Interesting addition. It took me a little while to see the purpose in having an image prefix or suffix, when you can just specify the image tag... but now I see it. You can have GitHub Docker decide the tag of the image, and prepend or append something you like to it. Nice stuff! |
|
@matootie I might even change this up a bit so we can use regex or something in the tag instead. |
|
@123FLO321 I very impatiently merged the PR already! 😆 Let's open up a new PR for that, if you'd like. |
| } | ||
| } | ||
| let imageTagPrefix = core.getInput('imageTagPrefix', { required: false }); | ||
| if (imageTagPrefix) imageName = imageTagPrefix + imageName; |
There was a problem hiding this comment.
I also made a mistake here (and 2 limes below)
Should be imageTag not imageName
There was a problem hiding this comment.
I've addressed this in #12
Take a look when you get the chance, and I'll put the fix in a new release.
2 participants
mrID(e.g.:mr1)imageTagPrefixandimageTagSuffixoptions