Question about clippy lints in the source code

[dare-to-recurse]

I noted in the Cargo.toml that a lot of lint groups are marked as allowed, with comments like "some sadness", along with specific lints marked as "TODO".

Would PRs that strictly focus on cleaning up these "TODO" lints be appreciated at this point in the project?

What about the lints classified as "some sadness"?
Do those need more consensus on if/how the lints should be applied before work can be done?

[x86pup]

We'd like to enforce as many clippy and rustc lints as possible, yes, to show we care about code cleanliness, quality, and safety. So PRs doing this are appreciated. They may not be high priority since we have a ton of coverage already, but they are fine to submit.

TODO and "some sadness" are the same thing, the "some sadness" ones were me just because they are the most complex ones to fix while being a fairly important lint to enforce and it would have taken hundreds of diffs to fix it.

I would say though try to consult with us in the development room on Matrix before putting in the work just in case we have any comments about the lint, and to reduce merge conflicts on other PRs, helps cooperate with all of us.

[dare-to-recurse]

Ok!

I'll hop in the development room at some point this week (or next weekend, depending on my job workload) to coordinate with you guys on that.

[jevolk]

We'd be happy to discuss before you take anything major on. Most of the linting project to address Conduit has now been completed. The lints marked for exclusion are entirely intentional at this point except those distinguished by TODO and even those few remaining might be philosophically questionable or disruptive rather than just not finished. There may be one or two errors and oversights though, so I'm always happy to review it annually.

One class of lints that are always overlooked but frankly need the most help and have the most impact are limits such as those in our clippy config. That's where I would advise will have the most impact.