Remove Dendrite skips from room upgrade push rule tests #822
+0
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
commented
Nov 21, 2025
| // from the old room to the new room at the time of upgrade. | ||
| t.Run(upgradeDescriptorPrefix+"upgrading a room carries over existing push rules for local users", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
CI is using https://codeload.github.com/element-hq/dendrite/tar.gz/12b7038989b9e3f6a7bbbd962196e2dd36ec13f0 corresponding to the commit that includes the fix in Dendrite (element-hq/dendrite@12b7038).
But the tests are still failing for the same reason:
❌ TestPushRuleRoomUpgrade/parallel/upgrading_a_room_carries_over_existing_push_rules_for_local_users (6.39s)
room_upgrade_test.go:89: Checking push rules (before upgrade) for @user-128-alice:hs1
room_upgrade_test.go:89: Checking push rules (before upgrade) for @user-129-alice2:hs1
room_upgrade_test.go:125: Upgraded room !elCWMwXxgKzi5gqO:hs1 to !GxZSg7a8AVeZ29Ie:hs1
room_upgrade_test.go:141: Checking push rules (after upgrade) for @user-128-alice:hs1
room_upgrade_test.go:143: @user-128-alice:hs1 MustSyncUntil: timed out after 5.04126244s. Seen 6 /sync responses. Checkers:
[t=32.802391ms] Response #1: Key account_data.events does not exist
[t=1.034544608s] Response #2: Key account_data.events does not exist
[t=2.036325764s] Response #3: Key account_data.events does not exist
[t=3.03838327s] Response #4: Key account_data.events does not exist
[t=4.039937578s] Response #5: Key account_data.events does not exist
[t=5.04125746s] Response #6: Key account_data.events does not exist,
[t=32.826866ms] Response #1: Key account_data.events does not exist
[t=1.034548655s] Response #2: Key account_data.events does not exist
[t=2.036330223s] Response #3: Key account_data.events does not exist
[t=3.038387698s] Response #4: Key account_data.events does not exist
[t=4.039940784s] Response #5: Key account_data.events does not exist
[t=5.041261107s] Response #6: Key account_data.events does not exist,
Collaborator
Author
There was a problem hiding this comment.
cc @S7evinK although no pressure for further development
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Dendrite skips from room upgrade push rule tests
element-hq/dendrite#3668 is now merged which should fix this kind of thing.
Follow-up to #819 (comment)
Pull Request Checklist
Signed-off-by: Eric Eastwood erice@element.io