Skip to content

Fix LookupWellKnown to read full response #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix LookupWellKnown to read full response #441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85fed40
Fix `LookupWellKnown` to read full response
richvdh Oct 29, 2024
ecbe67f
Merge branch 'main' into rav/fix_lookup_well_known
richvdh Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions fclient/well_known.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,10 @@ func LookupWellKnown(ctx context.Context, serverNameType spec.ServerName) (*Well
// by checking Content-Length, but it's possible that header will be
// missing. Better to be safe than sorry by reading no more than the
// WellKnownMaxSize in any case.
bodyBuffer := make([]byte, WellKnownMaxSize)
limitedReader := &io.LimitedReader{
R: resp.Body,
N: WellKnownMaxSize,
}
n, err := limitedReader.Read(bodyBuffer)
if err != nil && err != io.EOF {
body, err := io.ReadAll(&io.LimitedReader{R: resp.Body, N: WellKnownMaxSize})
if err != nil {
return nil, err
}
body := bodyBuffer[:n]

// Convert result to JSON
wellKnownResponse := &WellKnownResult{
Expand Down
Loading