-
Notifications
You must be signed in to change notification settings - Fork 155
Add a debug API endpoint to quit users who have been idle for a while #772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@turt2live I've given you the gift of ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also test failures - I thought we fixed that?
say what? |
|
I swear it was red when I started reviewing it |
f555102 to
a1fa782
Compare
|
(sorry for the force push, I thought I hadn't pushed before) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming the logging code outputs a compatible logger. Also if we have documentation on the debug API, we should put this endpoint in there.
And last thing: please rename the PR title before merging to better represent the thing.
| # "off" - Defaults to disabled, users can choose to enable. | ||
| # "force-off" - Disabled, cannot be enabled. | ||
| mapIrcMentionsToMatrix: "on" # This can be "on", "off", "force-off". | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
irrelevant diff
I checked, it does :).
We don't, but I'll add a wiki page. |
Fixes #388
This PR introduces the ability to periodically remove users who have not interacted with the bridge (or homeserver) in a given period. It uses matrix-lastactive in order to detect which users are offline.
This is checked first by local activity (e.g. sending messages/member events), then by presence (if enabled) and finally by use of the admin api for local users (if the user is allowed to make admin calls).
This fundamentally automates the process that matrix.org is already using for reaping users on it's Freenode bridge.