Skip to content

Conversation

@ntolazzi
Copy link
Contributor

@ntolazzi ntolazzi commented Mar 28, 2018

There was a tab in line 12 of the Makefile leading to the following error message when executing make:

commence before first target. Stop.

The tab was removed.

Signed-off-by: Nicolas Tolazzi nicolas.tolazzi@googlemail.com

@non-Jedi
Copy link
Collaborator

Hi @ntolazzi. I'm not seeing this error. Could you give me more info on e.g. what OS you're on and what make invocation gives this error? That's far from the only tab in the Makefile.

@non-Jedi
Copy link
Collaborator

Nevermind. I see it. This happens iff sphinx-build isn't installed. Thanks for the patch! I know it seems silly, but could you sign-off per CONTRIBUTING.rst? Thanks!

@ntolazzi
Copy link
Contributor Author

Not so sure whether I did the signing-off it correctly. I added the line to my initial comment, is that right?

@non-Jedi
Copy link
Collaborator

that works. thanks!

@non-Jedi non-Jedi merged commit 0bf05ac into matrix-org:master Mar 28, 2018
@ntolazzi ntolazzi deleted the fix_Makefile branch March 28, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants