Skip to content

Conversation

@AnthonyOfSeattle
Copy link
Contributor

@AnthonyOfSeattle AnthonyOfSeattle commented May 16, 2018

Fixes #197

Maintains:
Check response.json() for waittime specification

Changes:
Sets waittime to default before checking response.json().
Immediately raises unanticipated exceptions without sleeping.
Maintains default waittime if KeyError raised twice.

Signed-off-by: Anthony Valente valenta4@uw.edu

Sets waittime to default before checking response.json().
Immediately raises unanticipated exceptions without sleeping.
@AnthonyOfSeattle AnthonyOfSeattle changed the title Fixes #197: Ensure sleep is always called with a default waittime. Ensure sleep is always called with a default waittime. May 16, 2018
@non-Jedi non-Jedi added the bug label May 20, 2018
@non-Jedi
Copy link
Collaborator

LGTM. Thanks!

@non-Jedi non-Jedi merged commit f1da088 into matrix-org:master May 20, 2018
@AnthonyOfSeattle AnthonyOfSeattle deleted the 429-sleep-fix branch May 23, 2018 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants