Skip to content

Conversation

@Zil0
Copy link
Contributor

@Zil0 Zil0 commented Jun 28, 2018

Just one more to go!

Signed-off-by: Valentin Deniaud <valentin.deniaud@inpt.fr>

@Zil0 Zil0 changed the title Megolm inbound sessions [E2E] Megolm inbound sessions Jun 28, 2018
@Zil0
Copy link
Contributor Author

Zil0 commented Jul 30, 2018

@non-Jedi what do you think of 5f79968? This makes the decryption process totally transparent to SDK users (which is not very good when you want to tell them that an event is verified or not, but it will stay that way in this PR).

edit: well, it definitely is too transparent and should be changed in this PR, since an application is quite likely to need to know if a message was encrypted or not (as it cannot infer that a message was encrypted from the fact that it received it from an encrypted room, since messages can be always be sent unencrypted).
The solution would be to have an Event class, which simply subclasses dict (which can be changed to UserDict if needed in the future). For now, it would only add an encrypted (decrypted might be clearer) boolean attribute, and later a verified one. Thoughts?

@non-Jedi non-Jedi closed this Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants