Send token in Authorization header #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is there a reason to keep the old way around, the header seems like a net gain to me? |
Author
|
@Half-Shot I do not know of such reasons. just always try to leave compatibility. I can remove it if it's critical. |
Update from main
… behavior is customizable.
Collaborator
|
This is great! Thanks for all the new tests. This is good to merge once signed off on per CONTRIBUTING.rst. |
non-Jedi
approved these changes
Jul 18, 2018
Author
|
Signed-off-by: Pavel Kardash slipeer@gmail.com |
Collaborator
|
Cherry-picked into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default send user token in Authorization header istead of query string. Same behavior as in latest Riot.IM versions. As result more readeble query logs.
Tests for API _send method.