Add support for filename when uploading media #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zil0
reviewed
Aug 23, 2018
matrix_client/api.py
Outdated
|
|
||
| def media_upload(self, content, content_type): | ||
| def media_upload(self, content, content_type, filename=None): | ||
| query_params = dict() |
Contributor
There was a problem hiding this comment.
query_params = {} is the preferred way of doing this.
Contributor
|
Thanks, LGTM if not for the review comment :) |
Collaborator
|
LGTM once you signoff per Contributing.rst. Thanks! |
Signed-off-by: Denis Ryabyy <vv1r0x@gmail.com>
w1r0x
force-pushed
the
upload_filename
branch
from
b257da3 to
1a6a9fb
Compare
Contributor
Author
|
Changes done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with filename when uploading files
When you trying to save file through Riot app it saving it like this (without correct filename):
PR fix this issue by passing filename when uploading file