Skip to content

Conversation

@xsteadfastx
Copy link
Contributor

No description provided.

Copy link
Contributor

@Zil0 Zil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, lgtm if not for the docstring style. Directly amend your commit to make the change and this is good to go!

@Zil0
Copy link
Contributor

Zil0 commented Oct 8, 2018

I almost forgot, can you sign-off as explained in CONTRIBUTING.rst? Thanks!

@xsteadfastx
Copy link
Contributor Author

Signed-off-by: Marvin Steadfast marvin@xsteadfastx.org

@xsteadfastx
Copy link
Contributor Author

i hope its ok now

@Zil0 Zil0 merged commit 9e3e499 into matrix-org:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants