catch and log state event parse errors in _process_state_event #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zil0
suggested changes
Dec 7, 2018
Contributor
Zil0
left a comment
Zil0
left a comment
There was a problem hiding this comment.
Thanks! I had run into this before.
Two small changes and then we're good. As a side note, _process_state_event is starting to have too many levels of indentation, but this PR needn't fix this.
Zil0
reviewed
Dec 7, 2018
matrix_client/room.py
Outdated
| # limitations under the License. | ||
| import logging | ||
| import re | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe leave this change to the isort PR?
Zil0
approved these changes
Dec 7, 2018
Contributor
|
Squash accordingly, fix the newline that got added if you want, and this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently playing around with the sdk and was unable to instantiate a client due to a malformed state event present in one of the rooms I am a member.
The event was of type
m.room.guest_accessand contrary to spec had a zero lengthcontentfield.I'm unclear how this event was ever created, however it means that I (and presumably others), cannot create clients for any account that that participates in such a room.
This PR logs out the error, but ignores it and carries on.