Add new listeners #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
new-listeners
branch
from
c0af77a to
1228a7a
Compare
matrix_client/client.py
Outdated
| raise e | ||
| except Exception as e: | ||
| self.logger.error("Exception thrown during sync\n %s", str(e)) | ||
| self.logger.error("Exception thrown during sync\n %s", e) |
Member
There was a problem hiding this comment.
this should probably just use:
self.logger.exception("Exception thrown during sync")
Member
There was a problem hiding this comment.
Also, why is the logger not defined at the module level as:
logger = logging.getLogger(__name__)
Half-Shot
force-pushed
the
new-listeners
branch
from
b07bd14 to
97ef807
Compare
Changed logger.error to logger.exception
Half-Shot
force-pushed
the
new-listeners
branch
from
97ef807 to
76448ab
Compare
Member
|
flaaaaaaaaaaake8 |
Collaborator
Author
|
...I fixed and amended this...git please 😭 |
Fix logger spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes according to #46