Skip to content

Try using ergochat for CI testing #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Half-Shot merged 2 commits into from
Apr 25, 2023
Merged

Try using ergochat for CI testing #101

Half-Shot merged 2 commits into from
Apr 25, 2023

Conversation

@Half-Shot
Copy link

@Half-Shot Half-Shot commented Apr 25, 2023

Inspircd is a bit of a pain to modify the config of in GHA, and the defaults just ban our test rig outright. Ergo supports setting env flags so we can modify it if we need to.

@Half-Shot Half-Shot requested a review from a team as a code owner April 25, 2023 11:57
@Half-Shot Half-Shot changed the base branch from master to hs/node-20 April 25, 2023 11:57
tadzik
tadzik approved these changes Apr 25, 2023
View reviewed changes
Copy link

@tadzik tadzik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember about (ignoring?) the changelog :)

@Half-Shot Half-Shot merged commit 521f11c into hs/node-20 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tadzik tadzik tadzik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Half-Shot @tadzik