Skip to content

Conversation

@jesopo
Copy link

@jesopo jesopo commented May 28, 2020

see #45

@jesopo
Copy link
Author

jesopo commented May 28, 2020

I can see how this happened; if you look at the CAP ACK output from the test server in test.js:

raw:  { prefix: 'irc.dollyfish.net.nz',
  server: 'irc.dollyfish.net.nz',
  command: 'CAP',
  rawCommand: 'CAP',
  commandType: 'normal',
  args: [ '*', 'ACK', 'sasl ' ] }

note, the space after sasl in args

but if we point it at a different ircd...

raw:  { prefix: 'irc.darwin.network',
  server: 'irc.darwin.network',
  command: 'CAP',
  rawCommand: 'CAP',
  commandType: 'normal',
  args: [ '*', 'ACK', 'sasl' ] }

@jesopo
Copy link
Author

jesopo commented May 28, 2020

additionally, CAP ACK lines look like this when you CAP REQ more than just SASL:

:server CAP * ACK :account-notify sasl multi-prefix

@Half-Shot
Copy link

good catch, I think this is fine. @jesopo can I get a sign off from you as per https://github.com/matrix-org/matrix-appservice-irc/blob/master/CONTRIBUTING.md#making-pull-requests?

(Sorry it's not clear about that in the README, E_TOOMANYPROJECTS)

Copy link

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Signed-off-by: jesopo <github@lolnerd.net>
@jesopo
Copy link
Author

jesopo commented Aug 10, 2020

signed off

@Half-Shot Half-Shot merged commit f222abe into matrix-org:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants