feat(cli): connectivity checks for DB and embedding in interactive init#42
Merged
feat(cli): connectivity checks for DB and embedding in interactive init#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes
N/A — follow-up to #41
What this PR does / why we need it
Adds connectivity validation to
memoria init -iafter user confirms settings, before writing config files.Connectivity checks
Between the confirm step and writing config:
host:port(3s timeout) — catches wrong host/port/DB not running/embeddingswith{"model":"...","input":"test"}— verifies URL reachable, API key valid, model existsOn failure, shows the error and prompts
Continue anyway?so users can still write config if they plan to start services later.Other changes
collapsible_ifwarningscripts/migrate_embedding_dim.shto.gitignore(local-only utility)Changes
memoria/crates/memoria-cli/src/main.rscheck_db,check_embedding,check_embedding_requestfunctions; fixread_password_linetty fallback; clippy fix.gitignore