Skip to content

feat(cli): connectivity checks for DB and embedding in interactive init#42

Merged
aptend merged 3 commits intomainfrom
feat/onboard-guiding
Mar 18, 2026
Merged

feat(cli): connectivity checks for DB and embedding in interactive init#42
aptend merged 3 commits intomainfrom
feat/onboard-guiding

Conversation

@aptend
Copy link
Copy Markdown
Collaborator

@aptend aptend commented Mar 18, 2026

What type of PR is this?

  • feat (new feature)
  • chore (maintenance, tooling)

Which issue(s) this PR fixes

N/A — follow-up to #41

What this PR does / why we need it

Adds connectivity validation to memoria init -i after user confirms settings, before writing config files.

Connectivity checks

Between the confirm step and writing config:

  • Database: TCP connect to host:port (3s timeout) — catches wrong host/port/DB not running
  • Embedding: POST /embeddings with {"model":"...","input":"test"} — verifies URL reachable, API key valid, model exists

On failure, shows the error and prompts Continue anyway? so users can still write config if they plan to start services later.

Other changes

  • Fix clippy collapsible_if warning
  • Add scripts/migrate_embedding_dim.sh to .gitignore (local-only utility)

Changes

File Change
memoria/crates/memoria-cli/src/main.rs check_db, check_embedding, check_embedding_request functions; fix read_password_line tty fallback; clippy fix
.gitignore Ignore local migration script

@aptend aptend changed the title feat: interactive setup wizard and improved install script feat(cli): interactive setup wizard, install script improvements, and connectivity checks Mar 18, 2026
@aptend aptend changed the title feat(cli): interactive setup wizard, install script improvements, and connectivity checks feat(cli): connectivity checks for DB and embedding in interactive init Mar 18, 2026
@aptend aptend merged commit aedb529 into main Mar 18, 2026
6 checks passed
@XuPeng-SH XuPeng-SH deleted the feat/onboard-guiding branch March 20, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant