[Fix] DropDatabase: refresh snapshot after exclusive lock to prevent orphan records from concurrent CLONE#23767
Merged
heni02 merged 2 commits intomatrixorigin:3.0-devfrom Feb 25, 2026
Conversation
ouyuanning
approved these changes
Feb 25, 2026
…orphan records from concurrent CLONE When CLONE (CREATE TABLE) and DROP DATABASE execute concurrently, the lock service does not advance DROP's snapshot because CLONE only modifies mo_tables, not mo_database. This causes DROP to miss newly created tables, leaving orphan records in mo_tables that trigger OkExpectedEOB panic during checkpoint replay. Fix: after acquiring the exclusive lock in DropDatabase, explicitly advance the snapshot to the latest commit timestamp via GetLatestCommitTS + WaitLogTailAppliedAt + UpdateSnapshot, ensuring Relations() sees all tables committed before the lock was granted.
LeftHandCold
force-pushed
the
fix_clone+drop
branch
from
f2d975e to
c4f9ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23766
What this PR does / why we need it:
When CLONE (CREATE TABLE) and DROP DATABASE execute concurrently, the lock service does not advance DROP's snapshot because CLONE only modifies mo_tables, not mo_database. This causes DROP to miss newly created tables, leaving orphan records in mo_tables that trigger OkExpectedEOB panic during checkpoint replay.
Fix: after acquiring the exclusive lock in DropDatabase, explicitly advance the snapshot to the latest commit timestamp via GetLatestCommitTS + WaitLogTailAppliedAt + UpdateSnapshot, ensuring Relations() sees all tables committed before the lock was granted.