Skip to content

fix: support json prepared params#23982

Merged
mergify[bot] merged 2 commits intomatrixorigin:mainfrom
XuPeng-SH:fix-prepare-json-param
Mar 28, 2026
Merged

fix: support json prepared params#23982
mergify[bot] merged 2 commits intomatrixorigin:mainfrom
XuPeng-SH:fix-prepare-json-param

Conversation

@XuPeng-SH
Copy link
Copy Markdown
Contributor

@XuPeng-SH XuPeng-SH commented Mar 27, 2026

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #23981

What this PR does / why we need it:

This PR fixes a missing MYSQL_TYPE_JSON branch in the prepared-statement binary execute parser on main.

Without this change, COM_STMT_EXECUTE falls through to unsupport parameter type when a client sends a JSON-typed parameter through the binary protocol.

Focused validation:

  • go test ./pkg/frontend -run 'TestParseExecuteDataWithJSONParam'
  • go test ./pkg/frontend -run 'TestParseExecuteDataWithJSONParam|Test_StripPassword'

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Mar 27, 2026
@mergify mergify Bot added the kind/bug Something isn't working label Mar 27, 2026
@XuPeng-SH XuPeng-SH force-pushed the fix-prepare-json-param branch from 8b5fad3 to 9416b24 Compare March 27, 2026 16:30
@mergify mergify Bot added dequeued and removed queued labels Mar 28, 2026
XuPeng-SH and others added 2 commits March 28, 2026 09:25
@XuPeng-SH
fix: support json prepared params
1ef5d84 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@XuPeng-SH
test: strengthen json prepared param coverage
f6621f1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@XuPeng-SH XuPeng-SH force-pushed the fix-prepare-json-param branch from 9416b24 to f6621f1 Compare March 28, 2026 01:27
@mergify mergify Bot added queued and removed dequeued labels Mar 28, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 28, 2026 •
edited
Loading

Merge Queue Status

  • ✅ Entered queue — 2026-03-28 02:24 UTC · Rule: main
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-03-28 02:43 UTC · at f6621f1e34a44f9858fea756a152381a98c48923

This pull request spent 18 minutes 55 seconds in the queue, with no time running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-neutral = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
    • check-skipped = Matrixone Standlone CI / Multi-CN e2e BVT Test on Linux/x64(LAUNCH, PROXY)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH, PESSIMISTIC)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / SCA Test on Ubuntu/x86
    • check-neutral = Matrixone CI / SCA Test on Ubuntu/x86
    • check-skipped = Matrixone CI / SCA Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone CI / UT Test on Ubuntu/x86
    • check-neutral = Matrixone CI / UT Test on Ubuntu/x86
    • check-skipped = Matrixone CI / UT Test on Ubuntu/x86
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-neutral = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
    • check-skipped = Matrixone Compose CI / multi cn e2e bvt test docker compose(Optimistic/PUSH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-neutral = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
    • check-skipped = Matrixone Standlone CI / e2e BVT Test on Linux/x64(LAUNCH,Optimistic)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-neutral = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
    • check-skipped = Matrixone Upgrade CI / Compatibility Test With Target on Linux/x64(LAUNCH)
  • any of [🛡 GitHub branch protection]:
    • check-success = Matrixone Utils CI / Coverage
    • check-neutral = Matrixone Utils CI / Coverage
    • check-skipped = Matrixone Utils CI / Coverage

@mergify mergify Bot merged commit 7d6651b into matrixorigin:main Mar 28, 2026
23 of 24 checks passed
@mergify mergify Bot removed the queued label Mar 28, 2026
@jiangxinmeng1 jiangxinmeng1 mentioned this pull request Apr 24, 2026
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeftHandCold LeftHandCold LeftHandCold approved these changes

Assignees

No one assigned

Labels

kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XuPeng-SH @LeftHandCold @matrix-meow