frontend: optimize SHOW ACCOUNTS account-info SQL (#24092)#24113
Merged
mergify[bot] merged 1 commit intomatrixorigin:mainfrom Apr 10, 2026
Merged
frontend: optimize SHOW ACCOUNTS account-info SQL (#24092)#24113mergify[bot] merged 1 commit intomatrixorigin:mainfrom
mergify[bot] merged 1 commit intomatrixorigin:mainfrom
Conversation
Address matrixorigin#24091 by rewriting `getSqlForAccountInfo()` so `SHOW ACCOUNTS` computes database and table counts with separate aggregates instead of joining `mo_catalog.mo_tables` and `mo_catalog.mo_database` on `account_id` before `COUNT(DISTINCT ...)`. This removes the `mo_tables x mo_database` amplification that dominated the `getAccountInfo()` CPU flamegraph, pushes exact `account_id` filters into the aggregate CTEs for single-account requests, and keeps the rest of the `SHOW ACCOUNTS` behavior unchanged. As a low-risk follow-up, this PR also hardens reconstruction of the internal `LIKE` predicate by escaping single quotes and backslashes, and adds combined SQL-generation plus parser round-trip coverage. Approved by: @XuPeng-SH
XuPeng-SH
approved these changes
Apr 10, 2026
Contributor
Merge Queue Status
This pull request spent 11 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24091
What this PR does / why we need it:
Address #24091 by rewriting
getSqlForAccountInfo()soSHOW ACCOUNTScomputes database and table counts with separate aggregates instead of joiningmo_catalog.mo_tablesandmo_catalog.mo_databaseonaccount_idbeforeCOUNT(DISTINCT ...). This removes themo_tables x mo_databaseamplification that dominated thegetAccountInfo()CPU flamegraph, pushes exactaccount_idfilters into the aggregate CTEs for single-account requests, and keeps the rest of theSHOW ACCOUNTSbehavior unchanged. As a low-risk follow-up, this PR also hardens reconstruction of the internalLIKEpredicate by escaping single quotes and backslashes, and adds combined SQL-generation plus parser round-trip coverage.