Skip to content

Fix title text alignment - #496

Merged
matryer merged 1 commit into
matryer:masterfrom
guillaumewuip:fix-text-align
Nov 6, 2019
Merged

Fix title text alignment#496
matryer merged 1 commit into
matryer:masterfrom
guillaumewuip:fix-text-align

Conversation

@guillaumewuip

Copy link
Copy Markdown
Contributor

Before :
image

After :
image

Should fix #494, maybe #105

@mrienstra

Copy link
Copy Markdown

I tried this, worked for me.

macOS Mojave 10.14.2, Xcode 10.1 (10B61).

@jessemillar

Copy link
Copy Markdown

Is this going to be merged anytime soon?

@gingerbeardman

Copy link
Copy Markdown
Collaborator

Is this going to be merged anytime soon?

@jessemillar we can merge it once it passes Travis CI checks. Any ideas @guillaumewuip?

@mrienstra

Copy link
Copy Markdown

@gingerbeardman: I'm not 100% sure, but I don't believe the Travis CI build fail is due to the very small change @guillaumewuip made.

Looking at the last thing merged into master ( #371 ) I also see a build failure: https://travis-ci.org/matryer/bitbar/builds/163540241

@guillaumewuip

Copy link
Copy Markdown
Contributor Author

Yep I just look at the Travis build and I don't really understand why it fails @gingerbeardman
security import $CERT_P12 -k $KEYCHAIN -P "$CERT_PW" -T /usr/bin/codesign exits with code 1
How can I fix that ?

@gingerbeardman

Copy link
Copy Markdown
Collaborator

I have a feeling that was a temporarily Travis issue. Can we redo the CI somehow? Sorry

@guillaumewuip

Copy link
Copy Markdown
Contributor Author

Still failing apparently @gingerbeardman :'(

@gingerbeardman

Copy link
Copy Markdown
Collaborator

Thanks I'll raise it with the team

@luckman212

Copy link
Copy Markdown

Is this PR going to be merged? The vertical alignment thing is really an eyesore. Sorry to be a nag.

@thebitstick

Copy link
Copy Markdown

Any time now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vertical alignment of emoji seems off

7 participants