Skip to content

Leave flag.Parse() for go test#18

Merged
matryer merged 1 commit intomatryer:masterfrom
bremlforks:parse-flag
Oct 19, 2018
Merged

Leave flag.Parse() for go test#18
matryer merged 1 commit intomatryer:masterfrom
bremlforks:parse-flag

Conversation

@breml
Copy link
Copy Markdown
Contributor

@breml breml commented Jul 6, 2018

Fixes #17

@breml
Copy link
Copy Markdown
Contributor Author

breml commented Aug 14, 2018

@matryer can you please have a look at this PR, it just bite my again and I would really appreciate, if this could be fixed.

@breml
Copy link
Copy Markdown
Contributor Author

breml commented Sep 17, 2018

@matryer Could you please have a look at this PR and provide feedback or merge it?

@breml
Copy link
Copy Markdown
Contributor Author

breml commented Oct 18, 2018

@matryer Could you please have a look at this PR, because this bug is pretty annoying for us.

@matryer
Copy link
Copy Markdown
Owner

matryer commented Oct 18, 2018

Sorry @breml - does this change anything functionally?

@breml
Copy link
Copy Markdown
Contributor Author

breml commented Oct 19, 2018

@matryer under the assumption, that this library is only ever used for tests (read: in combination with go test), then there is no functional change, because go test does call flag.Parse().
Because in order to use this library one needs a *testing.T, I think it is pretty save to assume, that this library is only used with tests.

@matryer matryer merged commit 6f6891c into matryer:master Oct 19, 2018
@matryer
Copy link
Copy Markdown
Owner

matryer commented Oct 19, 2018

Great, thanks.

@breml breml deleted the parse-flag branch October 19, 2018 11:38
@breml
Copy link
Copy Markdown
Contributor Author

breml commented Oct 19, 2018

@matryer Thank you very much. Could you please tag a new release such that we can reference it with dep?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants