Skip to content

Conversation

@genya0407
Copy link
Contributor

Closes #23

Abstract

When we send a large HTTP body using a socket, it seems that the socket is broken because the body size is larger than its write buffer.

This PR divides HTTP bodies in order not to break sockets.

Note

  • I used https://httpbin.org/ in order to test HTTPS access. This may slow the test.
  • I added dependency for mruby-json in order to assert response from httpbin.
  • I removed skip from existing tests because they worked in my local environment.

@genya0407
Copy link
Contributor Author

I'm working in order to pass CI.

@matsumotory matsumotory merged commit e7e2e6c into matsumotory:master Mar 13, 2021
@matsumotory
Copy link
Owner

Thanks!

@genya0407 genya0407 deleted the feature/write-slicing-to-buf-size branch March 13, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POST request with a large body blocks forever

2 participants