Enhance failure logging and resilience in content generation process #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
preview
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling and resilience in Blake's content generation process by adding better logging and a continue-on-error option to prevent build failures from stopping the entire process. The primary goal is to make the baking process more robust when encountering individual content generation errors.
- Added
--continueOnErrorCLI flag to allow builds to continue despite individual page failures - Enhanced error logging throughout the content generation pipeline
- Fixed a bug where content index generation would fail if pages had null/missing tags
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Blake.CLI/Program.cs |
Added help text for the new --continueOnError CLI option |
src/Blake.BuildTools/Generator/SiteGenerator.cs |
Implemented continue-on-error logic with enhanced exception handling and logging in the content baking process |
src/Blake.BuildTools/Generator/ContentIndexBuilder.cs |
Added null-safe handling for page tags and continue-on-error support in content index generation |
- Updated `ContentIndexBuilder` to correctly handle `page.Tags`. - Added `ContinueOnError` and `Arguments` properties in `GeneratorOptions`. - Simplified error handling in `SiteGenerator` using `options.ContinueOnError`. - Removed `continueOnError` parameter from `BakeContent` method. - Updated `Program` to initialize `ContinueOnError` from command-line arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bake was failing with opaque error messages. This PR adds better logging, as well as a continue-on-error option for the CLI.
Additionally resolved an issue where content index generation would fail if any pages were missing tags.
🧷 This PR will be released as a preview by default.
To trigger a stable release:
previewlabelreleaselabelSemver-MinororSemver-Majorto control version bump🏷️ Add labels to control release notes:
enhancement,bug,breaking-change,dependenciesignore-for-releaseto suppress it from notes