-
Notifications
You must be signed in to change notification settings - Fork 2
Fix CI and publish workflow #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes GitHub Actions workflow configuration issues by properly structuring a reusable workflow call and simplifying secret management. The changes ensure the CI and publish workflows follow GitHub Actions best practices for reusable workflows.
- Restructures the publish job to use reusable workflow at the job level instead of step level
- Removes explicit secret passing in favor of
secrets: inheritpattern - Eliminates the
nuget_keyinput parameter from the reusable workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/reusable-publish.yml |
Removes nuget_key input parameter and updates step to use inherited secrets |
.github/workflows/ci.yml |
Converts publish job to use reusable workflow properly with secrets: inherit |
| with: | ||
| project_path: ${{ matrix.project.path }} | ||
| version: ${{ needs.generate-version.outputs.new_version }} | ||
| secrets: inherit | ||
| needs: generate-version |
Copilot
AI
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The needs dependency should be moved to the job level, not inside the job definition. It should be at the same indentation level as uses and with.
| with: | |
| project_path: ${{ matrix.project.path }} | |
| version: ${{ needs.generate-version.outputs.new_version }} | |
| secrets: inherit | |
| needs: generate-version | |
| needs: generate-version | |
| with: | |
| project_path: ${{ matrix.project.path }} | |
| version: ${{ needs.generate-version.outputs.new_version }} | |
| secrets: inherit |
| version: ${{ needs.generate-version.outputs.new_version }} | ||
| secrets: inherit | ||
| needs: generate-version | ||
| strategy: |
Copilot
AI
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strategy block is incompatible with reusable workflows. When using uses: at the job level, you cannot define a matrix strategy in the calling workflow. The matrix should be handled within the reusable workflow itself.
Summary
Fixes a couple of problems with the workflow:
🧷 This PR will be released as a preview by default.
To trigger a stable release:
previewlabelreleaselabelSemver-MinororSemver-Majorto control version bump🏷️ Add labels to control release notes:
enhancement,bug,breaking-change,dependenciesignore-for-releaseto suppress it from notes