Fetch changelogs concurrently for significant speed boost #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the suggestions in #66, this PR incorporates the
concurrent-rubygem to fetch changelogs concurrently. Doing so can yield a significant speed boost.For example, for a project with 80 outdated gems,
bundle uiin this PR now takes just 7 seconds to run from startup to rendering the complete list of changelogs:Whereas
bundle uion the main branch in the same scenario takes 36 seconds:For now I'm considering this a proof-of-concept. It may need testing and more error handling (e.g. to deal with HTTP 429 errors) prior to merging.Edit: To prevent overloading github.com and rubygems.org when fetching changelogs, I limited the concurrency to 25 threads. I tested with a project with over 100 outdated gems and did not encounter any 429 errors. Increasing the limit beyond 25 threads did not seem to yield any additional speed improvement.