-
Notifications
You must be signed in to change notification settings - Fork 141
Fix issues with parsing models on Python 3.9 #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,4 +6,5 @@ venv | |
| dist | ||
| .DS_Store | ||
| credentials/ | ||
| build/ | ||
| build/ | ||
| venv39/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ | |
| except: # noqa | ||
| # older python version | ||
| NoneType = type(None) | ||
| UnionType = type(int | str) | ||
| UnionType = type(Union) | ||
|
|
||
| CHIP_CLUSTERS_PKG_NAME = "home-assistant-chip-clusters" | ||
| CHIP_CORE_PKG_NAME = "home-assistant-chip-core" | ||
|
|
@@ -87,15 +87,20 @@ def parse_utc_timestamp(datetimestr: str): | |
| return datetime.fromisoformat(datetimestr.replace("Z", "+00:00")) | ||
|
|
||
|
|
||
| def parse_value(name: str, value: Any, value_type: Type | str, default: Any = MISSING): | ||
| def parse_value( | ||
| name: str, value: Any, value_type: Union[Type, str], default: Any = MISSING | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is inside an annotation so would have been fine.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, unrelated. The issue was the parsing of the actual annotations in this function itself. |
||
| ): | ||
| """Try to parse a value from raw (json) data and type definitions.""" | ||
| if isinstance(value, dict) and "_type" in value: | ||
| return dataclass_from_dict(None, value) | ||
| if isinstance(value_type, str): | ||
| # type is provided as string | ||
| if value_type == "type": | ||
| return locate(value) or eval(value) | ||
| value_type = eval(value_type) | ||
| try: | ||
| value_type = eval(value_type) | ||
| except TypeError: | ||
| pass | ||
|
|
||
| elif isinstance(value, dict): | ||
| if hasattr(value_type, "from_dict"): | ||
|
|
@@ -184,7 +189,7 @@ def parse_value(name: str, value: Any, value_type: Type | str, default: Any = MI | |
| return value | ||
|
|
||
|
|
||
| def dataclass_from_dict(cls: dataclass | None, dict_obj: dict, strict=False): | ||
| def dataclass_from_dict(cls: Optional[dataclass], dict_obj: dict, strict=False): | ||
| """ | ||
| Create (instance of) a dataclass by providing a dict with values. | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this doesn't work with
from __future__is because it is not written inside an annotation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, missed that while in the rush