Resynchronize CHIP Clusters with 5d8599d195a9#16
Merged
Conversation
Add the git hash of the CHIP project as Cluster Object version. This allows us to invalidate interviewing data when we add new Cluster objects. Once the spec is final, that should no longer be necessary. However, we might still need to add bug fixes to the Cluster objects. Maybe we should store the interviewing data in a known stable format, e.g. the Matter TLV format.
balloob
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds Cluster version as a git hash.
Add the git hash of the CHIP project as Cluster Object version. This
allows us to invalidate interviewing data when we add new Cluster
objects.
Once the spec is final, that should no longer be necessary. However, we
might still need to add bug fixes to the Cluster objects. Maybe we
should store the interviewing data in a known stable format, e.g. the
Matter TLV format.