Conversation
agners
reviewed
Jun 26, 2022
Collaborator
agners
left a comment
agners
left a comment
There was a problem hiding this comment.
I guess there might be other cases where we need to split a node into multiple devices, but I guess that would need another MappableDevice. Needs to be implemented when it comes up.
Contributor
Author
|
Marking as draft because I first want to merge entity description <> device mapping and then pick a better name for this too. |
balloob
force-pushed
the
add-mappable-device
branch
2 times, most recently
from
494c873 to
1271c6c
Compare
balloob
force-pushed
the
add-mappable-device
branch
from
a74cd31 to
81681cc
Compare
balloob
force-pushed
the
add-mappable-device
branch
from
abb488d to
89f68cd
Compare
Contributor
Author
|
Verified works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Matter nodes are a bridge that expose multiple devices. This adds support for this.
See architecture drawing for latest architecture that includes Matter Node Device: https://docs.google.com/drawings/d/1hxhOXKquTUooWH6sSfCfw02fyfIOYL9MoxJf6EBUQ9o/edit