Don't use threadsafe variant in signal_event#770
Merged
Conversation
All calls to signal_event are made in the asyncio event loop thread. Therefore, we don't need to use the threadsafe variant of call_soon() anymore. This was anyways a bit brittle as asyncio.create_task() is not threadsafe, so calling signal_event from a different thread was not really safe.
Collaborator
Author
|
Afaik, in practice this won't really make a difference as it is ok to call |
balloob
approved these changes
Jun 24, 2024
balloob
approved these changes
Jun 24, 2024
balloob
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All calls to signal_event are made in the asyncio event loop thread. Therefore, we don't need to use the threadsafe variant of call_soon() anymore.
This was anyways a bit brittle as asyncio.create_task() is not threadsafe, so calling signal_event from a different thread was not really safe.