Merged
Conversation
Override the liveness timeout when a node announces a shutdown. This causes the subscription logic to notice that the device went offline much quicker, which is especially nice for battery operated devices which have a high liveness timeout. We use 5s as timeout to make sure the device really completed shutdown, and that the first subscription resumption triggered by this actually fails. We can restore the timeout to default immediately after, since the SDK is in subscription resumption mode now. Another alternative would be to shutdown the subscription (mark the device as offline). This has the disadvantage that the device needs to recreate the subscription from scratch when it comes back, which causes unnecessary traffic. If the node stays offline for longer than 30s, we'll still trigger the offline logic which will shutdown the subscription entirely. This is mainly useful for updates, where the node goes offline gracefully (announced with the shutdown event) and comes back soon after.
agners
added
the
maintenance
MartinHjelmare
approved these changes
Jun 25, 2024
Contributor
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
I don't know the SDK details but Python wise it looks good.
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
agners
deleted the
shutdown-subscription-logic-attempt-with-livenss-timeout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override the liveness timeout when a node announces a shutdown. This causes the subscription logic to notice that the device went offline much quicker, which is especially nice for battery operated devices which have a high liveness timeout.
We use 5s as timeout to make sure the device really completed shutdown, and that the first subscription resumption triggered by this actually fails. We can restore the timeout to default immediately after, since the SDK is in subscription resumption mode now.
Another alternative would be to shutdown the subscription (mark the device as offline). This has the disadvantage that the controller needs to recreate the subscription from scratch when it comes back, which causes unnecessary traffic.
If the node stays offline for longer than 30s, we'll still trigger the offline logic which will shutdown the subscription entirely.