Enable dashboard in dev build#777
Merged
marcelveldt merged 4 commits intomatter-js:mainfrom Jul 3, 2024
Merged
Conversation
added 2 commits
June 29, 2024 16:45
Enabling Dashboard
bug fix.
marcelveldt
added
the
maintenance
Collaborator
|
@Chapoly1305 can you have a look at the issues found by the linter ? |
Use the installer provided on [Node.js website]. (https://nodejs.org/en/download/package-manager/current)
Author
|
@marcelveldt thanks for the notice. I adjusted the nodejs installer and use the official version, the previous in code was from a third-party website. Lint issue should also be fixed. |
MartinHjelmare
changed the title
MartinHjelmare
changed the title
Collaborator
|
Still a lint issue found ? |
Remove trailing spaces (right trim)
Author
|
Now it shall be all fixed. Please help to trigger the scan again, thanks! :) @marcelveldt |
marcelveldt
approved these changes
Jul 3, 2024
Collaborator
marcelveldt
left a comment
marcelveldt
left a comment
There was a problem hiding this comment.
Thanks, @Chapoly1305 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #776