MM-66625 - drop EnableChannelScopeAccessControl config#8856
Conversation
📝 WalkthroughWalkthroughDocumentation update to the ABAC channel access rules guide. Replaced two configuration-specific system-level ABAC enablement statements with a single, simplified UI path reference in System Console > System Attributes > Attribute-Based Access, whilst maintaining all other prerequisite conditions. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
source/administration-guide/manage/admin/abac-channel-access-rules.rst (1)
21-21:⚠️ Potential issue | 🟡 MinorAdd security note about user-managed attributes in ABAC rules for documentation consistency.
The prerequisites section omits important security information about
EnableUserManagedAttributesthat is included in other ABAC documentation files (abac-system-wide-policies.rst,attribute-based-access-control.rst, anduser-attributes.rst). All these files document that from Mattermost v10.11, user-managed attributes are excluded from ABAC rules by default for security reasons, and that admins must explicitly enable theEnableUserManagedAttributesconfiguration setting to include them.Since this file does not mention this security consideration, add a note after line 21 consistent with the security information in other ABAC files. Cross-references alone are insufficient—other ABAC documentation includes both the UI path and the security note about user-managed attributes directly in their prerequisites sections.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/administration-guide/manage/admin/abac-channel-access-rules.rst` at line 21, Add a security note after the prerequisites sentence that references the System Console path ("System Console > System Attributes > Attribute-Based Access") and states that since Mattermost v10.11 user-managed attributes are excluded from ABAC rules by default for security reasons and admins must explicitly enable the EnableUserManagedAttributes configuration to include them; mirror the language used in abac-system-wide-policies.rst and attribute-based-access-control.rst so the prerequisite section contains both the UI path and the explicit security note about EnableUserManagedAttributes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@source/administration-guide/manage/admin/abac-channel-access-rules.rst`:
- Line 21: Add a security note after the prerequisites sentence that references
the System Console path ("System Console > System Attributes > Attribute-Based
Access") and states that since Mattermost v10.11 user-managed attributes are
excluded from ABAC rules by default for security reasons and admins must
explicitly enable the EnableUserManagedAttributes configuration to include them;
mirror the language used in abac-system-wide-policies.rst and
attribute-based-access-control.rst so the prerequisite section contains both the
UI path and the explicit security note about EnableUserManagedAttributes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 914d5eb5-61bc-40a3-9a53-39ba2cfcbb7c
📒 Files selected for processing (1)
source/administration-guide/manage/admin/abac-channel-access-rules.rst
|
Newest code from mattermost has been published to preview environment for Git SHA 48fd743 |
|
@esethna - This one should be ready to go, covering PR #66625: mattermost/mattermost#35232 |
|
Newest code from mattermost has been published to preview environment for Git SHA 9fa0888 |
|
@pvev minor note for future: please base your changes off the docs branch for the 11.6 (or appropriate) version :) |
|
Newest code from mattermost has been published to preview environment for Git SHA af4cac2 |
Summary
Update documentation to reflect removal of redundant EnableChannelScopeAccessControl setting. Channel-level ABAC access is now controlled solely by the EnableAttributeBasedAccessControl config. Clarifies the System Console path for enabling ABAC system-wide.
References: Merged PR #35232 - Removes redundant EnableChannelScopeAccessControl configuration
Ticket Link
https://mattermost.atlassian.net/browse/MM-66625