Conversation
add missing data retention settings
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds documentation entries for Data Retention execution-rate and batch-control settings and three boolean deletion toggles, including their Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@source/administration-guide/configure/compliance-configuration-settings.rst`:
- Line 155: The text "positive integer (≥ 0)" is self-contradictory; determine
whether zero is allowed for this setting and replace the phrase consistently in
the document: if 0 is allowed change to "non-negative integer (≥ 0)", otherwise
change to "positive integer (> 0)"; update every occurrence of that phrase (the
lines containing "Default is 100 milliseconds. Possible values are any positive
integer (≥ 0).", and the other two occurrences noted) so the wording and the
parenthetical inequality agree.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a8ab182a-1328-4125-83cb-48141dda31a7
📒 Files selected for processing (1)
source/administration-guide/configure/compliance-configuration-settings.rst
There was a problem hiding this comment.
Pull request overview
Adds missing DataRetentionSettings documentation entries to the Mattermost compliance configuration reference, cleaning up leftover work from #8169 and ensuring admins can discover/tune data retention job behavior from the docs.
Changes:
- Documented additional
DataRetentionSettingsoptions in the Compliance > Data Retention Policies section. - Added config setting blocks for batch timing, batch sizing, boards retention days, and deletion enablement toggles.
|
Newest code from mattermost has been published to preview environment for Git SHA bd1d5fd |
|
@claude please address the review comments above |
|
Claude finished @esethna's task in 49s —— View job Addressing Review Comments
All review comments have been addressed in commit
|
…ference - Change "positive integer (≥ 0)" to "non-negative integer (≥ 0)" in three places - Add cross-reference to EnableBoardsDeletion in boards retention days description Co-authored-by: Eric Sethna <esethna@users.noreply.github.com>
|
Newest code from mattermost has been published to preview environment for Git SHA cd300c2 |
|
Newest code from mattermost has been published to preview environment for Git SHA b0fee7f |
OPened a new PR to clean up stale edits from: #8169