-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix build on Xcode 16.3 #8760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build on Xcode 16.3 #8760
Conversation
Coverage Comparison ReportGenerated on April 09, 2025 at 11:53:42 UTC |
|
Hi @enahum https://github.com/mattermost/mattermost-mobile/actions/runs/14349620462/job/40225812114?pr=8760 |
|
@toninis any idea why we are hitting some sort of rate limiting ? https://github.com/mattermost/mattermost-mobile/actions/runs/14351019192/job/40229835088?pr=8760 I did change the runner and the xcode version for the GHA |
app/components/post_list/thread_overview/__snapshots__/thread_overview.test.tsx.snap
Show resolved
Hide resolved
This seems to be a Github issue . We can introduce a Mattermost token to bypass those restrictions . |
This reverts commit a2a7a08.
No idea if there is a configuration for that.. anyway, let's see if it happens again, if it does, we can try and look further. |
|
@enahum @toninis there is no xcode 16.3. See this: actions/runner-images#11973. Will be available on their next VM update You can test using 16.3 RC though (see actions/runner-images#11916) |
|
@rahimrahman that is true, but I don't mind the CI using 16.2 as long as it compiles and also works for devs who have installed 16.3 on their machine |
|
@yasserfaraazkhan build fixed |
yasserfaraazkhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Elias
- verified installing the app
- Adding servers
- Switiching between different apps
- Sharing images from library
- report a problem
- posting messages, switching teams.
|
Merging |
Summary
This PR fixes the ability to build the app with Xcode 16.3 and updates all related dependencies.
Ticket Link
N/A
Checklist
Release Note