Skip to content

Conversation

@enahum
Copy link
Contributor

@enahum enahum commented Apr 9, 2025

Summary

This PR fixes the ability to build the app with Xcode 16.3 and updates all related dependencies.

Ticket Link

N/A

Checklist

  • Added or updated unit tests (required for all new features)

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Apr 9, 2025
@yasserfaraazkhan yasserfaraazkhan added the Build App for iOS Build the mobile app for iOS label Apr 9, 2025
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Coverage Comparison Report

Generated on April 09, 2025 at 11:53:42 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     85.28% |     85.28% |     0.00% |
| Statements      |     85.17% |     85.17% |     0.00% |
| Branches        |     70.94% |     70.94% |     0.00% |
| Functions       |     83.47% |     83.47% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     81.21% |     81.21% |     0.00% |
+-----------------+------------+------------+-----------+

@yasserfaraazkhan
Copy link
Contributor

Hi @enahum
the Build iOS app for PR build job fails. We can find the logs here.

https://github.com/mattermost/mattermost-mobile/actions/runs/14349620462/job/40225812114?pr=8760

@enahum enahum added Build App for iOS Build the mobile app for iOS and removed Build App for iOS Build the mobile app for iOS labels Apr 9, 2025
@enahum
Copy link
Contributor Author

enahum commented Apr 9, 2025

@toninis any idea why we are hitting some sort of rate limiting ? https://github.com/mattermost/mattermost-mobile/actions/runs/14351019192/job/40229835088?pr=8760

I did change the runner and the xcode version for the GHA

@enahum enahum removed the Build App for iOS Build the mobile app for iOS label Apr 9, 2025
@toninis
Copy link
Contributor

toninis commented Apr 9, 2025

@toninis any idea why we are hitting some sort of rate limiting ? https://github.com/mattermost/mattermost-mobile/actions/runs/14351019192/job/40229835088?pr=8760

I did change the runner and the xcode version for the GHA

This seems to be a Github issue . We can introduce a Mattermost token to bypass those restrictions .
Is there any configuration to limit the requests on Github ?

@enahum
Copy link
Contributor Author

enahum commented Apr 9, 2025

@toninis any idea why we are hitting some sort of rate limiting ? https://github.com/mattermost/mattermost-mobile/actions/runs/14351019192/job/40229835088?pr=8760
I did change the runner and the xcode version for the GHA

This seems to be a Github issue . We can introduce a Mattermost token to bypass those restrictions . Is there any configuration to limit the requests on Github ?

No idea if there is a configuration for that.. anyway, let's see if it happens again, if it does, we can try and look further.

@enahum enahum added the Build App for iOS Build the mobile app for iOS label Apr 9, 2025
@rahimrahman
Copy link
Contributor

@enahum @toninis there is no xcode 16.3. See this: actions/runner-images#11973. Will be available on their next VM update

You can test using 16.3 RC though (see actions/runner-images#11916)

@enahum
Copy link
Contributor Author

enahum commented Apr 9, 2025

@rahimrahman that is true, but I don't mind the CI using 16.2 as long as it compiles and also works for devs who have installed 16.3 on their machine

@enahum
Copy link
Contributor Author

enahum commented Apr 9, 2025

@yasserfaraazkhan build fixed

@yasserfaraazkhan yasserfaraazkhan removed the Build App for iOS Build the mobile app for iOS label Apr 10, 2025
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Elias

  • verified installing the app
  • Adding servers
  • Switiching between different apps
  • Sharing images from library
  • report a problem
  • posting messages, switching teams.

@enahum
Copy link
Contributor Author

enahum commented Apr 10, 2025

Merging

@enahum enahum merged commit 9a83813 into main Apr 10, 2025
19 checks passed
@enahum enahum deleted the deps branch April 10, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants