Skip to content

[GH-195] Send notification to channel when issue gets reopened#267

Merged
hanzei merged 1 commit intomattermost:masterfrom
maruTA-bis5:195-send-notify-reopen-issue-event-to-channel
Nov 22, 2021
Merged

[GH-195] Send notification to channel when issue gets reopened#267
hanzei merged 1 commit intomattermost:masterfrom
maruTA-bis5:195-send-notify-reopen-issue-event-to-channel

Conversation

@maruTA-bis5
Copy link
Contributor

Summary

Send notification to channel when the issue gets reopened.

Ticket Link

Fixes #195

@maruTA-bis5 maruTA-bis5 requested a review from iomodo as a code owner October 25, 2021 08:29
@mattermod
Copy link
Contributor

Hello @maruTA-bis5,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #267 (5d507c8) into master (5f463d2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   39.38%   39.45%   +0.06%     
==========================================
  Files          16       16              
  Lines        1795     1797       +2     
==========================================
+ Hits          707      709       +2     
  Misses       1011     1011              
  Partials       77       77              
Impacted Files Coverage Δ
server/webhook/issue.go 83.11% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f463d2...5d507c8. Read the comment docs.

@iomodo iomodo requested a review from hanzei October 25, 2021 15:07
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @maruTA-bis5 !

@hanzei hanzei requested a review from dipak-demansol October 25, 2021 18:53
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label Oct 25, 2021
@hanzei hanzei modified the milestones: v1.4.0, v1.5.0 Oct 25, 2021
@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

@emilyacook
Copy link

Thanks for participating in Hacktoberfest! You can claim your sticker set here: https://get.printfection.com/hacktober21/4144583267 @maruTA-bis5

@dipak-demansol
Copy link
Contributor

@hanzei LGTM but after a call with dylan i will add a Final Review.

Copy link
Contributor

@dipak-demansol dipak-demansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM For The New & Old Issue when It Reopen then i'm Getting The Notification.

@dipak-demansol dipak-demansol added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Nov 19, 2021
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed Lifecycle/1:stale QA Review Done PR has been approved by QA labels Nov 22, 2021
@hanzei hanzei merged commit bbed826 into mattermost:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-opening an issue does not deliver an event

6 participants