perf(android): add a cache object to avoid having to decrypt the alias in every access #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in every access
1 task
larkox
approved these changes
Nov 4, 2024
rahimrahman
approved these changes
Nov 4, 2024
Contributor
rahimrahman
left a comment
rahimrahman
left a comment
There was a problem hiding this comment.
If we're doing hundreds of requests (especially when app comes back to foreground), this could amount to a significant improvement.
enahum
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Android, we were decrypting the bearer token for every request we were making, and this was causing problems specially on Android 15. With this PR, we created a map that will hold the token in memory for quicker access without having to decrypt every time.