Add Kotlin unit test infrastructure and CircleCI step#159
Conversation
Add JUnit 4, Mockito, and OkHttp MockWebServer as test dependencies. These are needed to run the existing ExponentialRetryInterceptorTest and future interceptor tests. Co-authored-by: Claude <claude@anthropic.com>
- Add JUnit 4, Mockito, and OkHttp MockWebServer to android/build.gradle test dependencies - Add standalone test-runner project with Gradle wrapper for running Kotlin unit tests independently of the React Native build - Add kotlin-tests job to CircleCI using cimg/android executor - Add smoke test to verify the test infrastructure works - Wire kotlin-tests into the build workflow as a gate for build-package This enables TDD for Android interceptor code without requiring a full React Native app build. Co-authored-by: Claude <claude@anthropic.com>
Address CodeRabbit review: prevent resource leaks if assertions fail
by using Kotlin's use{} for automatic cleanup of MockWebServer and
Response objects.
Co-authored-by: Claude <claude@anthropic.com>
📝 WalkthroughWalkthroughThe changes establish a new Kotlin test-runner module with complete Gradle build infrastructure, integrate unit test execution into the CircleCI CI/CD pipeline via a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment Tip CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.Add a configuration file to your project to customize how CodeRabbit runs |
larkox
left a comment
larkox
left a comment
There was a problem hiding this comment.
And... yet another bleed. I saw that you had the whole test-runner folder in a different PR. Not sure if that was intended or not.
Apart of that, LGTM.
this only has test runner changes now |
|
Once this is approved and merged, I'll rebase #160 (which has tests that rely on this PR to run in CI). @jwilander - for some reason this repo still requires 2 reviewers, unlike other repositories. |
|
We just updated that because CodeRabbit was causing auto-merges to happen before a human looked at it. Context here: https://hub.mattermost.com/private-core/pl/1rc98y1obbfjzbknr7bfdfnc8y If CodeRabbit approves that will count as the second reviewer |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.circleci/config.yml (1)
69-83: Consider Gradle cache inkotlin-teststo reduce CI duration.The new job will repeatedly download wrapper/dependencies; adding cache should speed up runs and reduce flaky network impact.
💡 Suggested CI cache snippet
kotlin-tests: executor: android steps: - checkout + - restore_cache: + keys: + - gradle-test-runner-{{ checksum "test-runner/gradle/wrapper/gradle-wrapper.properties" }}-{{ checksum "test-runner/build.gradle.kts" }} + - gradle-test-runner- - run: name: Run Kotlin unit tests command: | cd test-runner ./gradlew test + - save_cache: + key: gradle-test-runner-{{ checksum "test-runner/gradle/wrapper/gradle-wrapper.properties" }}-{{ checksum "test-runner/build.gradle.kts" }} + paths: + - ~/.gradle/caches + - ~/.gradle/wrapper - store_test_results: path: test-runner/build/test-results - store_artifacts: path: test-runner/build/reports/tests destination: kotlin-test-reports🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.circleci/config.yml around lines 69 - 83, Add a Gradle cache for the kotlin-tests job to avoid re-downloading the wrapper and dependencies: modify the kotlin-tests job (job name "kotlin-tests", step running "./gradlew test" in "test-runner") to add CircleCI cache restore/save steps for Gradle files (e.g., ~/.gradle and the Gradle wrapper in test-runner/.gradle or test-runner/.gradle/wrapper) using a key that includes the OS and gradle wrapper checksum, restore the cache before running ./gradlew test and save it after the build finishes so subsequent runs reuse downloaded dependencies and speed up CI.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.circleci/config.yml:
- Around line 69-83: Add a Gradle cache for the kotlin-tests job to avoid
re-downloading the wrapper and dependencies: modify the kotlin-tests job (job
name "kotlin-tests", step running "./gradlew test" in "test-runner") to add
CircleCI cache restore/save steps for Gradle files (e.g., ~/.gradle and the
Gradle wrapper in test-runner/.gradle or test-runner/.gradle/wrapper) using a
key that includes the OS and gradle wrapper checksum, restore the cache before
running ./gradlew test and save it after the build finishes so subsequent runs
reuse downloaded dependencies and speed up CI.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 427be98c-a605-43a7-8916-7e0f72ce10db
⛔ Files ignored due to path filters (1)
test-runner/gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jar
📒 Files selected for processing (8)
.circleci/config.ymlandroid/build.gradletest-runner/build.gradle.ktstest-runner/gradle/wrapper/gradle-wrapper.propertiestest-runner/gradlewtest-runner/gradlew.battest-runner/settings.gradle.ktstest-runner/src/test/kotlin/com/mattermost/networkclient/SmokeTest.kt
|
@pavelzeman & @larkox, do we even use CircleCI anymore? |
We dont't use it anymore, but we did when this repo was created although this repo never had it active and all the releases are done manually |
5 participants
Summary
Add infrastructure for running Kotlin unit tests in CI. Currently the repo has one Kotlin test file (
ExponentialRetryInterceptorTest.kt) but no test dependencies inbuild.gradleand no CI step to run them.The Android side of this library has 36 Kotlin files totaling ~3,250 lines of code — including interceptors for auth, retry, compression, timeouts, and metrics. That's a decent amount of logic with no test coverage in CI. This PR fixes that.
Ticket Link
N/A — infrastructure improvement to support ongoing Sentry issue fixes.
Release Note
Changes
android/build.gradle: AddtestImplementationdependencies for JUnit 4, Mockito, and OkHttp MockWebServertest-runner/: Standalone Gradle project with wrapper for running Kotlin unit tests independently of the React Native build. Includes a smoke test to verify the infrastructure works..circleci/config.yml: Addkotlin-testsjob usingcimg/androidexecutor, wired as a gate forbuild-packageWhy a standalone test-runner?
The Android module (
android/build.gradle) is a library that depends on React Native at build time, making it difficult to run./gradlew teststandalone. Thetest-runnerproject provides a lightweight Kotlin+JVM environment with OkHttp dependencies — enough to test interceptor logic without the full React Native build chain.What this enables
Migrated from #156 (fork → org branch)