Patching Callback Routes for Load and Uninstall#1
Patching Callback Routes for Load and Uninstall#1VitaliJud wants to merge 3 commits intomatthewvolk:mainfrom
Conversation
matthewvolk
left a comment
There was a problem hiding this comment.
Looks good, and thank you for the PR! Just one quick fix if you don't mind 😄
There was a problem hiding this comment.
Thank you @VitaliJud ! This all looks good, but do you mind removing this file from the PR? I want to make sure VSCode settings are added explicitly by the user instead of automatically.
|
👋 Happened to realize something while revisiting this project. That In other words, this PR won't functionally change anything about how the app loads and uninstalls, but it does highlight that the requiring of that parameter is confusing if the |
All 3 routes were using the same callback url - /auth/install which was failing to load the app.