Skip to content

Patching Callback Routes for Load and Uninstall#1

Closed
VitaliJud wants to merge 3 commits intomatthewvolk:mainfrom
VitaliJud:main
Closed

Patching Callback Routes for Load and Uninstall#1
VitaliJud wants to merge 3 commits intomatthewvolk:mainfrom
VitaliJud:main

Conversation

@VitaliJud
Copy link

All 3 routes were using the same callback url - /auth/install which was failing to load the app.

Copy link
Owner

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thank you for the PR! Just one quick fix if you don't mind 😄

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @VitaliJud ! This all looks good, but do you mind removing this file from the PR? I want to make sure VSCode settings are added explicitly by the user instead of automatically.

@matthewvolk matthewvolk reopened this Jan 22, 2025
@matthewvolk
Copy link
Owner

matthewvolk commented Jan 22, 2025

👋 Happened to realize something while revisiting this project. That authCallback param is only ever used in the bigrequest.oauth.authorize method (here), and never in the bigrequest.oauth.verify methods that are called on the load and uninstall routes (here)

In other words, this PR won't functionally change anything about how the app loads and uninstalls, but it does highlight that the requiring of that parameter is confusing if the bigrequest client is only being used for JWT verification.

Edit:
matthewvolk/bigrequest#518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants