Authentication, Type/Value checks, Use of News API error messages, and addressed a Windows cmd error#11
Merged
mattlisiv merged 6 commits intomattlisiv:masterfrom Apr 4, 2018
Merged
Conversation
Type and Value Errors on newsapi_client.py
Owner
|
Hi @banta-isaiah , Thanks for the update. I really like the way these type checks are handled with the library. A few things I think need to be adjusted:
if language not in const.languages:rather than containing a 'is' .
Thanks! |
fixed line 211 to read `if language not in const.language` changed parameter `to_param` to `to`
Contributor
Author
|
Done! Let me know if there is anything else you see an issue with |
Owner
|
@banta-isaiah, it looks like you still have the to_param set as an argument within the function (line 121) . def get_everything(self, q=None, sources=None, domains=None, from_param=None, to_param=None, language=NoneOnce that is corrected, everything looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toparameter toto_paramin order to be consistent withfrom_paramto_paramandfrom_paramvaluesintsrelated to page parameters