Allowing country + category searches for news.#12
Merged
mattlisiv merged 1 commit intomattlisiv:masterfrom Apr 18, 2018
Merged
Conversation
The newsapi allows news queries with both country and category parameters in the payload. However, it doesn't allow country and source or category and source mixed parameters. The update to the code reflects the corrected parameter options.
mattlisiv
approved these changes
Apr 18, 2018
Owner
mattlisiv
left a comment
mattlisiv
left a comment
There was a problem hiding this comment.
You are correct. Thanks for catching that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newsapi module allows news queries with both country and category
parameters inthe payload. However, it doesn't allow country and source or
category and source mixed parameters. The update to the code reflects the
corrected parameter options.