Skip to content

Correct Error Message and Add Unit Tests#19

Merged
mattlisiv merged 3 commits intomattlisiv:masterfrom
TobiAlbert:master
Aug 15, 2018
Merged

Correct Error Message and Add Unit Tests#19
mattlisiv merged 3 commits intomattlisiv:masterfrom
TobiAlbert:master

Conversation

@TobiAlbert
Copy link
Copy Markdown
Contributor

I understand the pytest module has been added, and you expect tests to be written using it but I just couldn't get it to work.

I don't know what the issue is, but I noticed that I can't pass a decorated '@pytest.fixture' function as a parameter into another function.

ie

@pytest.fixture
def foo():
return Object()

def test_bar(foo):
foo.do_something()

- Simplify 'if statement' comparison
@mattlisiv
Copy link
Copy Markdown
Owner

Hi @TobiAlbert ,

Thanks for the tests! Very helpful. However, I would ask that you revert the changes to newsapi_client.py that change the TypeError message. It could be confusing to change the coment from 'str' to 'string', because 'str' and 'string' are two seperate modules in Python.

After that is resolved, I will merge.

Best,
Matt

@TobiAlbert
Copy link
Copy Markdown
Contributor Author

Hi @mattlisiv,

I've reverted the changes to newsapi_client.py.

Thanks,
Tobi.

@mattlisiv mattlisiv merged commit f59f9d6 into mattlisiv:master Aug 15, 2018
@mattlisiv
Copy link
Copy Markdown
Owner

Awesome, thanks @TobiAlbert. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants