Correct Error Message and Add Unit Tests#19
Merged
mattlisiv merged 3 commits intomattlisiv:masterfrom Aug 15, 2018
Merged
Conversation
- Simplify 'if statement' comparison
Owner
|
Hi @TobiAlbert , Thanks for the tests! Very helpful. However, I would ask that you revert the changes to newsapi_client.py that change the TypeError message. It could be confusing to change the coment from 'str' to 'string', because 'str' and 'string' are two seperate modules in Python. After that is resolved, I will merge. Best, |
…s and Error Messages.
Contributor
Author
|
Hi @mattlisiv, I've reverted the changes to newsapi_client.py. Thanks, |
Owner
|
Awesome, thanks @TobiAlbert. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand the pytest module has been added, and you expect tests to be written using it but I just couldn't get it to work.
I don't know what the issue is, but I noticed that I can't pass a decorated '@pytest.fixture' function as a parameter into another function.
ie
@pytest.fixture
def foo():
return Object()
def test_bar(foo):
foo.do_something()