added exclude domain parameter#24
Merged
mattlisiv merged 1 commit intomattlisiv:masterfrom Oct 1, 2018
Merged
Conversation
Owner
|
Hi @jborchma, Thanks for the addition! Merged. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Matt,
when going through the API docs I noticed that the excludeDomains keyword was missing from the Python API
get_everythingmethod. I added it in the same form as the other keywords had been added and included testing for the new variable in the same form as you had done for the others. I also added an entry into the docstring.I just noticed my text editor also got rid of whitespaces in empty lines and at the end of the lines, I hope that's ok too. So the main changes are around lines 180.
Let me know what you think!
Cheers,
Jan