Adding new countries and languages that were missing#41
Merged
mattlisiv merged 1 commit intomattlisiv:masterfrom Sep 6, 2019
menarguez:newsapy-python-new-countries-and-languages
Merged
Adding new countries and languages that were missing#41mattlisiv merged 1 commit intomattlisiv:masterfrom menarguez:newsapy-python-new-countries-and-languages
mattlisiv merged 1 commit intomattlisiv:masterfrom
menarguez:newsapy-python-new-countries-and-languages
Conversation
- New countries: ["pk", "es", "is", "se", "zh"] - New languages:["se", "zh"])
Owner
|
@menarguez I do not see these new additions in the official documentation online. Do you have a source where you found these? Thanks! |
Contributor
Author
|
I did so by pulling all sources from the API. As I was using the const as the True value list of candidate items, storage of sources failed. Adding these fixed the problem |
Collaborator
|
These are referenced here: (Looks like i accidentally duplicated part of this PR in #44. Sorry for not looking here first.) |
Owner
|
Great. At the time, the official documentation did not have the new additions, so I was hesitant to add, but all good now. Thanks! |
Contributor
Author
|
It has been a while but thanks for merging this back in the day and thanks for the new additions as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"zh"])