Skip to content

Conversation

@github-actions
Copy link
Contributor

Summary

Mypy currently reports attr-defined errors because types.ModuleType has no dotenv_values attribute. We fake a dotenv module in tests but haven’t told mypy about it.

Affected file

  • tests/test_config.py

Implementation Details

Added inline # type: ignore[attr-defined] comments to the two fake_dotenv.dotenv_values assignments to suppress these mypy errors in tests.

Assumptions

  • Only tests in tests/test_config.py require this change. No changes to production code needed.

Testing

  • uv run mypy tests/test_config.py — no issues found.
  • uv run pytest tests/test_config.py — tests pass.

Considerations

Chose inline type ignores for minimal impact and to keep tests clear. Alternatively could configure mypy to ignore the entire file, but inline ignores are more targeted.

@github-actions github-actions bot added the oai label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants