Replace hard-coded log path with XDG data directory #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace hard-coded log path with XDG-compliant data directory using get_data_dir(), update tests, and apply style fixes.
Implementation Details
get_data_dir()insetup_logging()and removed the hard-coded~/.oai_coding_agentpath.DATA_DIR/agent.loginstead of~/.oai_coding_agent/agent.log.tests/test_logger.pyandtests/console/test_console.pyto import and useget_data_dir()at the top-level.Path) in logger and console modules.logger.pyandconsole/console.pyto satisfy ruff import style rules.Assumptions & Style Decisions
get_data_dir()to the top-level to comply with the existing ruff PLC0415 rule (imports should be at the top). This deviates from the example diff but maintains repository-wide import style.Testing
Ran the following checks:
All checks and tests passed successfully.