Remove GitHub Directory #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved the GitHub browser authentication module into the existing
authpackage and removed the obsoletegithubdirectory. Updated all relevant imports and tests to reflect the new module path.Implementation Details
github_browser_auth.pyfromsrc/oai_coding_agent/githubtosrc/oai_coding_agent/auth.tests/githubtotests/authand updated imports intest_github_browser_auth.py.GitHubConsole(src/oai_coding_agent/console/github_console.py) to use the newauth.github_browser_authmodule.src/oai_coding_agent/githubdirectory.# ruff: noqa: I001directive to suppress minor import-sorting errors ingithub_console.py.Assumptions Made
tests/authdirectory will house tests for authentication-related modules, aligning with the relocated code.githubpackage.main.Testing
Ran the full suite of project checks and tests:
uv run ruff check uv run ruff format uv run mypy . uv run pytestAll checks and tests passed successfully.
Considerations
githubpackage for backward compatibility, but consolidating underauthstreamlines the module structure.