implement skill should verify it's on an appropriate feature branch before starting work #1023
JGormanAlphaSimplex
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Right now the
implementskill just says "Commit your work to the current branch," with no check on what that branch actually is. In practice this means it'll happily start implementing work -- and committing -- straight ontomain/master, or onto some unrelated branch left over from a previous task.I'd like
implementto add a quick branch sanity-check as its first step, with two rules:mainormaster, stop and ask the user to create/switch to a feature branch before doing any implementation work.fix-typowhile implementing "add OAuth support"), flag this to the user and ask them to confirm or switch, rather than silently proceeding. This should be a loose judgment call, not a strict naming-convention check -- only flag obvious mismatches, not just imperfect names.Suggested addition to
skills/engineering/implement/SKILL.md, right after the frontmatter:Happy to be told this is better handled elsewhere (e.g. a shared pre-flight check reused across skills) -- just flagging the gap as I hit it in
implementspecifically.All reactions