Add envfile input format #39
Conversation
|
Please add this to the Thank you! |
jinja2cli/cli.py
Outdated
| """ | ||
| dict_ = {} | ||
| for line in data.splitlines(): | ||
| line = line.strip() |
There was a problem hiding this comment.
I think strip() has to be called after split(=), so both key & value have the spaces removed. eg. supporting foo = blah blah blah.
There was a problem hiding this comment.
That's not how envfile format works. If you used that value, you'd be getting a key of "foo " and a value of " blah blah blah", and would be intended behavior for environment variables. See my reference material in the issue.
There was a problem hiding this comment.
I also changed this to lstrip since it should only be stripping preceding spaces, not trailing spaces.
There was a problem hiding this comment.
Also based on what you originally said "dotenv", there are implementation of that that wouldn't cover what you're saying either:
https://www.npmjs.com/package/dotenv#rules for example which is much closer to what I wrote here. I'm matching Docker's behavior.
Fixes GH-38