Conversation
The CryptoKit library was introduced with iOS 13, so every version of Xcode with the iOS 13+ SDK (Xcode 11+) can build code that imports CryptoKit. This change doesn't affect OneTimePassword's runtime support for earlier iOS versions, because the runtime check and CommonCrypto fallback remain.
The codebase no longer supports compiling with Swift 4.2
Codecov Report
@@ Coverage Diff @@
## develop #230 +/- ##
===========================================
+ Coverage 96.35% 96.97% +0.62%
===========================================
Files 6 6
Lines 384 364 -20
===========================================
- Hits 370 353 -17
+ Misses 14 11 -3
Continue to review full report at Codecov.
|
mattrubin
added a commit
that referenced
this pull request
Dec 28, 2022
CryptoKit is required as of #230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CryptoKit library was introduced with iOS 13, so every version of Xcode with the iOS 13+ SDK (Xcode 11+) can build code that imports CryptoKit. This change doesn't affect OneTimePassword's runtime support for earlier iOS versions, because the runtime check and CommonCrypto fallback remain.
Also, delete pre-Swift 5.0 code paths that should have been removed in the previous PR.